Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

fix: docker build on erlang 25 #216

Merged
merged 10 commits into from
Jan 24, 2023
Merged

fix: docker build on erlang 25 #216

merged 10 commits into from
Jan 24, 2023

Conversation

nlwstein
Copy link
Contributor

@nlwstein nlwstein commented Jan 18, 2023

This PR attempts to solve the Docker build issue presenting on main by removing distillery.

Reason: bitwalker/distillery#744

The approach taken here is similar to this commit: mbta/concentrate@a9b4d57

It also adds a Docker build job to the Elixir workflow that runs on PRs.

@nlwstein
Copy link
Contributor Author

nlwstein commented Jan 18, 2023

@bklebe This PR is to address the failure that occurred when #215 was merged.

It may be worth a chat tomorrow to test this further locally, since it does rip out a part of the release process and I cannot test the image fully locally without some secrets I do not have currently loaded into env vars.

I am also going to go through and make sure each repo has it's Docker image building correctly as well, though at least half of the repos seem to already have a Docker image build on commit test.

@nlwstein nlwstein requested a review from bklebe January 18, 2023 23:35
@nlwstein nlwstein marked this pull request as ready for review January 18, 2023 23:36
@bklebe
Copy link
Member

bklebe commented Jan 20, 2023

@nlwstein I would recommend a dev deploy to see if it boots at least.

@bklebe bklebe temporarily deployed to dev January 24, 2023 16:55 — with GitHub Actions Inactive
@bklebe
Copy link
Member

bklebe commented Jan 24, 2023

Just tried a dev deploy, looks good to me.

@nlwstein nlwstein merged commit 31353fb into main Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants