Tighten Ruby version requirement to avoid Symbol#inspect bug in previous versions
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prikha
force-pushed
the
tighten-ruby-version-requirement
branch
from
661e577
to
b833e12
Compare
mbj
reviewed
Jan 18, 2024
| @@ -23,7 +23,7 @@ Gem::Specification.new do |gem| | |||
|
|
|||
| gem.metadata['rubygems_mfa_required'] = 'true' | |||
|
|
|||
| gem.required_ruby_version = '>= 3.0' | |||
| gem.required_ruby_version = '>= 3.2' | |||
There was a problem hiding this comment.
I cannot remove support for 3.0 and 3.1 right now. Not until they are EOL. I'll have to fix this via a conditional around the Symbol#inspect usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original bug:
https://bugs.ruby-lang.org/issues/18905
Resolves: #359