6 1 #2470
Draft
6 1 #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed writing pages in the same thread that does EnqueuePage
…context Don't capture synchronization context in DiskWriterQueue
…ion-in-ensure 2451 lazy string interpolation in ensure
# Conflicts: # LiteDB/Engine/Disk/DiskWriterQueue.cs
2451 fix disk writer queue
ltetak
commented
Apr 10, 2024
| { | ||
| public static class Logging | ||
| { | ||
| public static event Action<LogEventArgs> LogCallback; |
There was a problem hiding this comment.
Have at least some simple mechanism to hook to logs and log them - to reveal what is wrong if it fails in production
ltetak
commented
Apr 10, 2024
Comment on lines
+82
to
+85
| public bool IsDisposed => _state.Disposed; | ||
|
|
||
| private readonly TaskCompletionSource<bool> _closedTask = new TaskCompletionSource<bool>(); | ||
| public Task<bool> Closed => _closedTask.Task; |
There was a problem hiding this comment.
give a chance to outside observer to check
if (db.IsDisposed)
{
await db.Closed;
}
recreate db
ltetak
commented
Apr 10, 2024
Comment on lines
-109
to
+111
| _state.Handle(ex); | ||
| _state.Handle(LiteException.InvalidDatafileState(ex, "DiskWriterQueue failed")); |
There was a problem hiding this comment.
make DiskWriterQueue exceptions "fatal" - these can't be survived and it is best to tear down the entire engine and let the outside observer to restart the engine (possibly with a rebuild)
ltetak
commented
Apr 10, 2024
Comment on lines
+113
to
123
| ExhaustQueue(); | ||
| } | ||
| } | ||
|
|
||
| private void ExhaustQueue() | ||
| { | ||
| while (_queue.TryDequeue(out var page)) | ||
| { | ||
| page.Release(); | ||
| } | ||
| } |
There was a problem hiding this comment.
If anything fails here we need to drop this object - this means all pages must be released (including the one that caused the failure - see the finally case below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello the LiteDB community. I would like to open a discussion about the stability of this tool. I have some thoughts first and then there is a draft here about some recent changes + some quick wins.