Fix security issue for V4 #2424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag? |
Hello ! Thank you for your response. My branch was created on the v4.1.4 tag. (commit 918b650). |
viveleltsi
force-pushed
the
bugfix/fix-security-issue
branch
from
d3182c2
to
3f7eac9
Compare
|
I rebase my branch onto the V4 branch (commit 46a8387) and I rebuild it and run the unit testing. It's all good. |
|
Nice! Thanks.... Could you create a pull request for v4 branch? Than I will create a new tag for this new release |
|
Yes of course. I updated this PR to target the v4 branch. |
|
@mbdavid I updated the PR to the v4 branch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the severity issue for the old v4 liteDB version.
The goal is to have a patch for application who cannot update to V5.
Because this is my first PR for this project I think my changes should be properly checked and validated.
fix #2418
PS: This branch should not be merged on master but probably stay on a fix branch.