Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Source Generator to be incremental #2404

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

pictos
Copy link

@pictos pictos commented Jan 7, 2024

This PR updates the SG to use incremental and improve it:

  • With the incremental behavior the generated interfaces will be created/updated just when makes sense for them;
  • Just add unsafe when the class has unsafe code;
  • Use Roslyn to determine the members, so no need to use strings or store an array of C# keywords;

There's more that can be done to improve the perf even more, but since it's use internally and just create interfaces I believe this is a good start point and better than the previous implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant