Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring query executor to ensure that transaction is released #2024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gzatravkin
Copy link

It removes some duplications and fixes the problem that when you are using
query.Select(...).FirstOrDefault() won't release the transaction, and eventually, it will lead to a crash when trying to enter exclusive mode.

It was happening because it wasn't advancing after
yield return _query.Select.ExecuteScalar(_pragmas.Collation).AsDocument;

Now releases the transaction inside of finally block, which will be called with Dispose method

Fix for query executor crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant