v1.0.5

mbalabash · Mar 27, 2023 · 4e3e1f6 · 4e3e1f6
1 parent 0afcf7d
commit 4e3e1f6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 23 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.0.5
+
+- Dropped support for [createBrowserFetcher](https://pptr.dev/api/puppeteer.puppeteernode.createbrowserfetcher#remarks)
+
 ## 1.0.4
 
 - Added support for node-14

diff --git a/example/index.js b/example/index.js
@@ -1,19 +1,21 @@
-import { join } from 'path'
-import puppeteer from 'puppeteer-core'
-import { PUPPETEER_REVISIONS } from 'puppeteer-core/lib/cjs/puppeteer/revisions.js'
-import { findChrome } from 'find-chrome-bin'
+const { join } = require('path')
+const puppeteer = require('puppeteer-core')
+const { PUPPETEER_REVISIONS } = require('puppeteer-core/lib/cjs/puppeteer/revisions.js')
+const { findChrome } = require('../index')
 
-let chromeInfo = await findChrome({
-  min: 92,
-  max: 95,
-  download: {
-    puppeteer,
-    path: join('.', 'chrome'),
-    revision: PUPPETEER_REVISIONS.chromium
-  }
-})
+;(async () => {
+  let chromeInfo = await findChrome({
+    min: 92,
+    max: 128,
+    download: {
+      puppeteer,
+      path: join('../test', 'chrome'),
+      revision: PUPPETEER_REVISIONS.chromium
+    }
+  })
 
-console.log(chromeInfo)
+  console.log(chromeInfo)
+})()
 
 // package.json
 // {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "find-chrome-bin",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Finds local Chromium binary to use it with puppeteer-core",
   "keywords": [
     "chrome",

diff --git a/src/chrome/index.js b/src/chrome/index.js
@@ -42,21 +42,14 @@ function chromeVersion(executablePath) {
   ).trim()
 }
 
-function createBrowserFetcher(puppeteer, path, host) {
-  if (puppeteer.BrowserFetcher) {
-    return new puppeteer.BrowserFetcher({ path, host })
-  }
-  return puppeteer.createBrowserFetcher({ path, host })
-}
-
 async function downloadChromium(puppeteer, path, revision) {
   try {
     let downloadHost =
       process.env.PUPPETEER_DOWNLOAD_HOST ||
       process.env.npm_config_puppeteer_download_host ||
       process.env.npm_package_config_puppeteer_download_host
 
-    let browserFetcher = createBrowserFetcher(puppeteer, path, downloadHost)
+    let browserFetcher = new puppeteer.BrowserFetcher({ path, host: downloadHost })
 
     let revisionInfo = browserFetcher.revisionInfo(revision)