Add Transaction Reporting functionality #88
Conversation
PatrickCronin
force-pushed
the
pcronin/report-txns
branch
5 times, most recently
from
4c36b0a
to
151c8d1
Compare
PatrickCronin
force-pushed
the
pcronin/report-txns
branch
from
151c8d1
to
90342e8
Compare
README.md
Outdated
| @@ -77,7 +77,13 @@ Page](https://maxmind.github.io/minfraud-api-php/) under the "API" tab. | |||
|
|
|||
| ## Usage ## | |||
|
|
|||
| To use this API, create a new `\MaxMind\MinFraud` object. The constructor | |||
| This library provides access to both the [minFraud2 (Score, Insights and | |||
There was a problem hiding this comment.
"minFraud2" is an internal name. We should just use "minFraud" in public documentation. The same applies below.
README.md
Outdated
| MaxMind encourages the use of this API as data received through this channel is | ||
| used to continually improve the accuracy of our fraud detection algorithms. | ||
|
|
||
| To use the Report Transactions API, create a new `\MaxMind\ReportTransaction` |
There was a problem hiding this comment.
I didn't notice this before, but I wonder if \MaxMind\MinFraud\ReportTransaction would be a better name. It is a minFraud API, just not one of our scoring APIs.
Similarly, \MaxMind\ServiceClients could lead to accidental name collisions with our other client APIs.
There was a problem hiding this comment.
I've made this change.
| * @dataProvider services | ||
| * | ||
| * @param mixed $class | ||
| * @param mixed $service | ||
| */ | ||
| public function testMissingIpAddress($class, $service) | ||
| { | ||
| $this->expectException(InvalidInputException::class); | ||
| $this->expectExceptionMessage('Must have keys'); |
There was a problem hiding this comment.
Nice. I wasn't saying you had to do these ones as part of the story, but it is good that we won't have to deal with them later.
There was a problem hiding this comment.
Yeah, no worries. It was just a couple regexp finds/replaces.
PatrickCronin
force-pushed
the
pcronin/report-txns
branch
from
90342e8
to
2f47a78
Compare
dev-bin/release.sh
Outdated
| @@ -44,7 +44,7 @@ fi | |||
| php composer.phar self-update | |||
| php composer.phar update --no-dev | |||
|
|
|||
| perl -pi -e "s/(?<=const VERSION = ').+?(?=';)/$tag/g" src/MinFraud.php | |||
| perl -pi -e "s/(?<=const VERSION = ').+?(?=';)/$tag/g" src/ServiceClient.php | |||
There was a problem hiding this comment.
Thanks -- great catch! I've rebased this in with the initial abstraction commit.
PatrickCronin
force-pushed
the
pcronin/report-txns
branch
from
2f47a78
to
04496d0
Compare
In order to encourage more usage of the minFraud Report Transaction API, this PR adds a method to this client library that simplifies transaction reporting.