Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up hugo site and migrate homepage #1131

Merged
merged 5 commits into from May 9, 2024
Merged

Set up hugo site and migrate homepage #1131

merged 5 commits into from May 9, 2024

Conversation

kevcenteno
Copy link
Member

No description provided.

Copy link
Contributor

@dhogan8 dhogan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I had just some minor feedback.

assets/scss/btn.scss Outdated Show resolved Hide resolved
assets/scss/btn.scss Show resolved Hide resolved
assets/scss/_product-featured.scss Outdated Show resolved Hide resolved
assets/scss/btn.scss Show resolved Hide resolved
assets/scss/btn.scss Outdated Show resolved Hide resolved
Comment on lines +6 to +7
{{ $style := resources.Get "scss/index.scss" }} {{ $options := dict
"transpiler" "dartsass" }} {{ $style := $style | resources.ToCSS $options}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ $style := resources.Get "scss/index.scss" }} {{ $options := dict
"transpiler" "dartsass" }} {{ $style := $style | resources.ToCSS $options}}
{{ $style := resources.Get "scss/index.scss" }}
{{ $options := dict "transpiler" "dartsass" }}
{{ $style := $style | resources.ToCSS $options}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually gonna change this to use the libsass compiler. It also looks like prettier did this formatting change (assuming this was a formatting suggestion)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna walk back the libsass change as it's been marked deprecated by the sass team 😓

layouts/partials/head.html Show resolved Hide resolved
@kevcenteno kevcenteno requested a review from dhogan8 May 9, 2024 17:40
@kevcenteno kevcenteno merged commit 209d0d0 into hugo May 9, 2024
14 of 16 checks passed
@kevcenteno kevcenteno deleted the kevin/hugo branch May 9, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants