Merge pull request capricorn86#549 from obadakhalili/task/548-fix-sel…

…ect-selectedIndex-incorrect-logic capricorn86#548@patch: Fix incorrect logic in selectEl.selectedIndex setter.
maxmilton · Jul 24, 2022 · f7c8a89 · f7c8a89
2 parents ec5a307 + d4e47b5
commit f7c8a89
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 43 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/happy-dom/src/nodes/html-select-element/HTMLSelectElement.ts b/packages/happy-dom/src/nodes/html-select-element/HTMLSelectElement.ts
@@ -171,7 +171,7 @@ export default class HTMLSelectElement extends HTMLElement implements IHTMLSelec
 	 * @param value Value.
 	 */
 	public set selectedIndex(value: number) {
-		if (this.options.length - 1 > value || value < 0) {
+		if (value > this.options.length - 1 || value < 0) {
 			throw new DOMException(
 				'Select elements selected index must be valid',
 				DOMExceptionNameEnum.indexSizeError