Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix internal session keys with underscore #470

Merged
merged 1 commit into from Feb 6, 2020

Conversation

alanhamlett
Copy link
Collaborator

To prevent accidental usage in app code. Fixes #465.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5e3b9ea on alanhamlett:master into 5fce013 on maxcountryman:master.

Copy link
Owner

@maxcountryman maxcountryman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@alanhamlett alanhamlett merged commit 1d1a3a8 into maxcountryman:master Feb 6, 2020
killthekitten added a commit to killthekitten/sqlalchemy-continuum that referenced this pull request May 2, 2020
Tests were failing since the FlaskLogin extension has prefixed
internal variable names with an underscore:

maxcountryman/flask-login#470
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session["user_id"] = user.id authenticates user
3 participants