Upgrade packages #637
Merged
Upgrade packages #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Security vulnerabilities and a big flask upgrade made us want to upgrade this.
One thing to note: Flask-Login moved 'user_id' in the session to '_user_id' (as part of maxcountryman/flask-login#470), but we actually use the key in the messages code (specifically https://github.com/ONSdigital/response-operations-ui/blob/main/response_operations_ui/views/messages.py#L691)... so I've added to the session when you log in. We could use the new '_user_id' value but we don't want to rely on 'internal' flask-login values incase they one day decide to call it something else or just remove it.
The changes to the components have been updated in the design system too.
How to test?
Trello