Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extracting from buffers by only using yauzl.open if it's a string. #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow extracting from buffers by only using yauzl.open if it's a string. #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c5fe5
only attempt to open a file if it's a string
foxt Aug 20, 2020
d50d665
Make the linter happy
foxt Aug 20, 2020
f613f07
Make the linter happy
foxt Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const stream = require('stream')
const yauzl = require('yauzl')

const openZip = promisify(yauzl.open)
const openBuffer = promisify(yauzl.fromBuffer)
const pipeline = promisify(stream.pipeline)

class Extractor {
Expand All @@ -19,7 +20,7 @@ class Extractor {
async extract () {
debug('opening', this.zipPath, 'with opts', this.opts)

this.zipfile = await openZip(this.zipPath, { lazyEntries: true })
this.zipfile = await (typeof this.zipPath === 'string' ? openZip : openBuffer)(this.zipPath, { lazyEntries: true })
this.canceled = false

return new Promise((resolve, reject) => {
Expand Down