Form field automatically remapping after being unmapped

[fedys]

Q	A
Bug fix? (use the a.b branch)	[✅]
New feature/enhancement? (use the a.x branch)	[❌]
Deprecations?	[❌]
BC breaks? (use the c.x branch)	[❌]
Automated tests included?	[✅]
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description:

This PR fixes the following bugs:

1. Icons for mapped form fields are not displayed in the form field listing.

Screen.Recording.2024-05-13.at.15.00.42.mov

2. A non-mapped existing form field is auto-mapped when being edited.

Screen.Recording.2024-05-13.at.15.53.43.mov

Steps to test this PR:

1. Icons for mapped form fields are not displayed in the form field listing.
   1. When adding a new mapped form field the icon indicating mapping should be visible right after clicking the "Add" button. See the first screen recording in the description.
2. 1. Create a form with at least one non-mapped field of type "Email" and click “Save & Close”.
   2. Go back to the form edit page and refresh your browser.
   3. Click the "Pencil" icon to update the form field you created at 1. step.
   4. Navigate to the "Mapped Field" tab. The field should not be mapped to a contact's email. See the second screen recording in the description.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (4883fa0) to head (55c976d).

❗ Current head 55c976d differs from pull request most recent head 47cb187

Please upload reports for the commit 47cb187 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##                5.x   #13744      +/-   ##
============================================
+ Coverage     61.62%   61.72%   +0.10%     
+ Complexity    34145    34101      -44     
============================================
  Files          2245     2241       -4     
  Lines        102077   101937     -140     
============================================
+ Hits          62909    62925      +16     
+ Misses        39168    39012     -156     

Files	Coverage Δ
app/bundles/FormBundle/Entity/Field.php	91.28% <100.00%> (+12.21%)	⬆️
app/bundles/FormBundle/Form/Type/FieldType.php	67.57% <100.00%> (+0.91%)	⬆️

... and 17 files with indirect coverage changes

[escopecz]

I see no issue in the code 👍 Thanks!

[kuzmany]

I found another issue, do not investigate if it's related to code in the PR, but it's worth checking.
If the form returns an error, then the last added field disappears.

Zaznam.2024-05-13.202639.mp4

[fedys]

I found another issue, do not investigate if it's related to code in the PR, but it's worth checking. If the form returns an error, then the last added field disappears.

Zaznam.2024-05-13.202639.mp4

@kuzmany Thanks for point it out! This issue is reproducible in 5.x too.