-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sms improvements #13743
Open
escopecz
wants to merge
9
commits into
mautic:5.x
Choose a base branch
from
escopecz:sms-improvements
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sms improvements #13743
+194
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongilbert
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
escopecz
added
enhancement
Any improvement to an existing feature or functionality
sms
Anything related to SMS
unforking
Used for PRs in the Acquia's unforking initiative
code-review-passed
PRs which have passed code review
labels
May 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13743 +/- ##
============================================
+ Coverage 61.51% 61.78% +0.27%
- Complexity 34068 34095 +27
============================================
Files 2241 2241
Lines 101852 101921 +69
============================================
+ Hits 62651 62972 +321
+ Misses 39201 38949 -252
|
escopecz
added
the
pending-test-confirmation
PR's that require one test before they can be merged
label
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-review-passed
PRs which have passed code review
enhancement
Any improvement to an existing feature or functionality
pending-test-confirmation
PR's that require one test before they can be merged
sms
Anything related to SMS
unforking
Used for PRs in the Acquia's unforking initiative
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is an enhancement code that we needed to build a plugin that was adding some new tokens to SMS sending. It improves the code:
Steps to test this PR: