Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert charset to utf8mb4 to resolve invalid character issues #13722

Open
wants to merge 8 commits into
base: 5.x
Choose a base branch
from

Conversation

dadarya0
Copy link
Contributor

@dadarya0 dadarya0 commented May 6, 2024

Q A
Bug fix? (use the a.b branch) No
New feature/enhancement? (use the a.x branch) Yes
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? No
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Older instances that were created before the MySQL8 upgrades are using an outdated format. By migrating all tables issues like character encoding will be resolved.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Make sure your table does not have utf8mb4 charset
  3. Insert some Japanese character in text field or description field.
  4. it should be saved and rendered properly
  5. search filter should work fine.

@dadarya0 dadarya0 requested review from a team and escopecz and removed request for a team May 6, 2024 09:29
@escopecz escopecz added ready-to-test PR's that are ready to test db-migrations unforking Used for PRs in the Acquia's unforking initiative labels May 6, 2024
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue with the code. I've run the migration but I don't have a database that would have other than utf8mb4_unicode_ci encoding so it did nothing.

@escopecz escopecz added the code-review-passed PRs which have passed code review label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review db-migrations ready-to-test PR's that are ready to test unforking Used for PRs in the Acquia's unforking initiative
Projects
Status: ⏳︎ Needs 1 more test
Development

Successfully merging this pull request may close these issues.

None yet

3 participants