Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Minimalist backgrounds #13714

Merged
merged 2 commits into from May 14, 2024

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented May 1, 2024

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Yeah, this one may sound a bit boring.
Some changes were made so most of the main pages inherit the background color only removing bg classes.
It also makes separators invisible when you're creating a new contact or company: only space, no clutter.

Why?

  • Because it becomes easier to work with colors across the entire ui
  • Things get minimalist and clean, community seems to like it
  • Minimalist interfaces are easier to build for new features thinking on your side
  • It's based on feedback regarding lack of contrast, another PR were made to help and this one extends it and prepare for more
Before After
image image

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Contacts > Create new
  3. Look at the fields and the page itself, there's a chance that you won't notice the difference

———

Pending tasks

  • Revert hr style changes
  • Remove hr tags from twig
  • Include remaining tables on this PR, removing vertical lines and stripes
  • Check again all pages to include instead of delivering only for main pages

@andersonjeccel andersonjeccel self-assigned this May 1, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality labels May 1, 2024
@andersonjeccel andersonjeccel added this to the 5.2 milestone May 1, 2024
@andersonjeccel andersonjeccel requested review from shinde-rahul, a team and ricfreire May 3, 2024 10:52
@andersonjeccel andersonjeccel added code-review-passed PRs which have passed code review pending-test-confirmation PR's that require one test before they can be merged and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels May 5, 2024
@andersonjeccel andersonjeccel added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels May 11, 2024
@escopecz escopecz modified the milestones: 5.2, 5.1.0 May 14, 2024
@escopecz escopecz merged commit 4883fa0 into mautic:5.x May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Status: 🥳 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants