Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dreprecated from (self::MASTER_REQUEST) to (self::MAIN_REQUEST) #13712

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

Oluwatos94
Copy link

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Navigate to the app/middlewares/Dev/IpRestrictMiddleware.php directory.
  3. press ctrl-f in your code editor environment (Vs code) to find self::MASTER_REQUEST which is the deprecated constant.

Steps taken to resolve this problem on all located files:

  1. search for the constant self::MASTER_REQUEST
  2. replaced with self::MAIN_REQUEST

@Oluwatos94
Copy link
Author

@RCheesley, Please you can now review this. I have resolved in all the locations as requested.

@RCheesley RCheesley added the code-review-needed PR's that require a code review before merging label May 10, 2024
@Oluwatos94
Copy link
Author

Oluwatos94 commented May 11, 2024

Hello, @RCheesley! you could try to test the code now. I have made some adjustment by changing deprecated constants HttpKernelInterface::MASTER_REQUEST to HttpKerrnelInterface::MAIN_REQUEST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-needed PR's that require a code review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants