Refactor deprecated setMethod in unit tests

mautic · Mar 29, 2021 · 0ef00c2 · 0ef00c2
1 parent 21cc28b
commit 0ef00c2
Show file tree

Hide file tree

Showing 30 changed files with 68 additions and 68 deletions.
diff --git a/app/bundles/ApiBundle/Tests/Controller/CommonApiControllerTest.php b/app/bundles/ApiBundle/Tests/Controller/CommonApiControllerTest.php
@@ -74,7 +74,7 @@ public function testgetWhereFromRequestWithSomeWhere()
         ];
 
         $request = $this->getMockBuilder(Request::class)
-            ->setMethods(['get'])
+            ->onlyMethods(['get'])
             ->disableOriginalConstructor()
             ->getMock();
 

diff --git a/app/bundles/CacheBundle/Tests/EventListener/CacheClearSubscriberTest.php b/app/bundles/CacheBundle/Tests/EventListener/CacheClearSubscriberTest.php
@@ -35,7 +35,7 @@ public function setUp(): void
         $this->random  = sha1((string) time());
         $this->adapter = $this->getMockBuilder(FilesystemTagAwareAdapter::class)
             ->disableOriginalConstructor()
-            ->setMethods(['clear', 'getCacheAdapter', 'commit'])
+            ->onlyMethods(['clear', 'getCacheAdapter', 'commit'])
             ->getMock();
         $this->adapter->method('clear')->willReturn($this->random);
         $this->adapter->method('commit')->willReturn(null);

diff --git a/app/bundles/CampaignBundle/Tests/Entity/CampaignRepositoryTest.php b/app/bundles/CampaignBundle/Tests/Entity/CampaignRepositoryTest.php
@@ -76,7 +76,7 @@ public function testFetchEmailIdsById(): void
 
         $queryBuilder = $this->getMockBuilder(QueryBuilder::class)
             ->disableOriginalConstructor()
-            ->setMethods(['select', 'from', 'where', 'setParameter', 'andWhere', 'getQuery'])
+            ->onlyMethods(['select', 'from', 'where', 'setParameter', 'andWhere', 'getQuery'])
             ->getMock();
 
         $this->entityManager
@@ -110,7 +110,7 @@ public function testFetchEmailIdsById(): void
 
         $query = $this->getMockBuilder(AbstractQuery::class)
             ->disableOriginalConstructor()
-            ->setMethods(['setHydrationMode', 'getResult'])
+            ->onlyMethods(['setHydrationMode', 'getResult'])
             ->getMockForAbstractClass();
 
         $query->expects(self::once())

diff --git a/app/bundles/CampaignBundle/Tests/Model/EventModelTest.php b/app/bundles/CampaignBundle/Tests/Model/EventModelTest.php
@@ -33,7 +33,7 @@ protected function setUp(): void
     {
         $this->eventModel = $this->getMockBuilder(EventModel::class)
             ->disableOriginalConstructor()
-            ->setMethods([
+            ->onlyMethods([
                 'getRepository',
                 'getLeadEventLogRepository',
                 'deleteEntities',

diff --git a/app/bundles/ChannelBundle/Tests/EventListener/CampaignSubscriberTest.php b/app/bundles/ChannelBundle/Tests/EventListener/CampaignSubscriberTest.php
@@ -308,7 +308,7 @@ public function sendMarketingMessageSms(CampaignExecutionEvent $event)
     private function getEvent()
     {
         $event = $this->getMockBuilder(Event::class)
-            ->setMethods(['getId'])
+            ->onlyMethods(['getId'])
             ->getMock();
         $event->method('getId')
             ->willReturn(1);
@@ -375,7 +375,7 @@ private function getLogs()
             );
 
         $log = $this->getMockBuilder(LeadEventLog::class)
-            ->setMethods(['getLead', 'getId'])
+            ->onlyMethods(['getLead', 'getId'])
             ->getMock();
         $log->method('getLead')
             ->willReturn($lead);
@@ -400,7 +400,7 @@ private function getLogs()
             );
 
         $log2 = $this->getMockBuilder(LeadEventLog::class)
-            ->setMethods(['getLead', 'getId'])
+            ->onlyMethods(['getLead', 'getId'])
             ->getMock();
         $log2->method('getLead')
             ->willReturn($lead2);

diff --git a/app/bundles/CoreBundle/Test/EventListener/CoreSubscriberTest.php b/app/bundles/CoreBundle/Test/EventListener/CoreSubscriberTest.php
@@ -171,7 +171,7 @@ public function testOnKernelController()
 
         $request    = $this->createMock(Request::class);
         $controller = $this->getMockBuilder(MauticController::class)
-            ->setMethods(['initialize', 'setRequest', 'setFactory', 'setUser', 'setCoreParametersHelper', 'setDispatcher', 'setTranslator', 'setFlashBag'])
+            ->onlyMethods(['initialize', 'setRequest', 'setFactory', 'setUser', 'setCoreParametersHelper', 'setDispatcher', 'setTranslator', 'setFlashBag'])
             ->getMock();
         $controllers = [$controller];
 

diff --git a/app/bundles/CoreBundle/Tests/Unit/Entity/CommonRepositoryTest.php b/app/bundles/CoreBundle/Tests/Unit/Entity/CommonRepositoryTest.php
@@ -40,7 +40,7 @@ class CommonRepositoryTest extends \PHPUnit\Framework\TestCase
     protected function setUp(): void
     {
         $emMock = $this->getMockBuilder(EntityManager::class)
-            ->setMethods(['none'])
+            ->onlyMethods(['none'])
             ->disableOriginalConstructor()
             ->getMock();
 

diff --git a/app/bundles/DynamicContentBundle/Tests/Helper/DynamicContentHelperTest.php b/app/bundles/DynamicContentBundle/Tests/Helper/DynamicContentHelperTest.php
@@ -24,7 +24,7 @@ public function testGetDwcBySlotNameWithPublished(): void
     {
         $mockModel = $this->getMockBuilder(DynamicContentModel::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntities'])
+            ->onlyMethods(['getEntities'])
             ->getMock();
 
         $mockModel->expects($this->exactly(2))

diff --git a/app/bundles/EmailBundle/Tests/EventListener/TokenSubscriberTest.php b/app/bundles/EmailBundle/Tests/EventListener/TokenSubscriberTest.php
@@ -101,7 +101,7 @@ public function testDynamicContentCustomTokens()
         /** @var TokenSubscriber $subscriber */
         $subscriber = $this->getMockBuilder(TokenSubscriber::class)
             ->setConstructorArgs([$dispatcher, $primaryCompanyHelper])
-            ->setMethods(null)
+            ->onlyMethods(null)
             ->getMock();
 
         $dispatcher->addSubscriber($subscriber);

diff --git a/app/bundles/EmailBundle/Tests/Helper/PointEventHelperTest.php b/app/bundles/EmailBundle/Tests/Helper/PointEventHelperTest.php
@@ -52,7 +52,7 @@ private function getMockMauticFactory($published = true, $success = true)
     {
         $mock = $this->getMockBuilder(MauticFactory::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getModel'])
+            ->onlyMethods(['getModel'])
             ->getMock()
         ;
 
@@ -95,7 +95,7 @@ private function getMockEmail($published = true, $success = true)
 
         $mock = $this->getMockBuilder(EmailModel::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntity', 'sendEmail'])
+            ->onlyMethods(['getEntity', 'sendEmail'])
             ->getMock()
         ;
 

diff --git a/app/bundles/EmailBundle/Tests/Model/SendEmailToContactTest.php b/app/bundles/EmailBundle/Tests/Model/SendEmailToContactTest.php
@@ -257,7 +257,7 @@ function ($param) {
 
         $mailHelper = $this->getMockBuilder(MailHelper::class)
             ->setConstructorArgs([$factoryMock, $mailer])
-            ->setMethods(['createEmailStat'])
+            ->onlyMethods(['createEmailStat'])
             ->getMock();
 
         $mailHelper->method('createEmailStat')
@@ -416,7 +416,7 @@ function ($eventName, EmailSendEvent $event) {
 
         $mailHelper = $this->getMockBuilder(MailHelper::class)
             ->setConstructorArgs([$factoryMock, $mailer])
-            ->setMethods(null)
+            ->onlyMethods(null)
             ->getMock();
 
         // Enable queueing
@@ -519,7 +519,7 @@ function ($param) {
 
         $mailHelper = $this->getMockBuilder(MailHelper::class)
             ->setConstructorArgs([$factoryMock, $mailer])
-            ->setMethods(['createEmailStat'])
+            ->onlyMethods(['createEmailStat'])
             ->getMock();
 
         $mailHelper->expects($this->exactly(21))
@@ -656,7 +656,7 @@ function ($param) {
 
         $mailHelper = $this->getMockBuilder(MailHelper::class)
             ->setConstructorArgs([$factoryMock, $mailer])
-            ->setMethods(['createEmailStat'])
+            ->onlyMethods(['createEmailStat'])
             ->getMock();
 
         $mailHelper->method('createEmailStat')

diff --git a/app/bundles/FormBundle/Tests/EventListener/ReportSubscriberTest.php b/app/bundles/FormBundle/Tests/EventListener/ReportSubscriberTest.php
@@ -46,7 +46,7 @@ public function testOnReportBuilderAddsFormAndFormSubmissionReports()
     {
         $mockEvent = $this->getMockBuilder(ReportBuilderEvent::class)
             ->disableOriginalConstructor()
-            ->setMethods([
+            ->onlyMethods([
                 'checkContext',
                 'addGraph',
                 'getStandardColumns',
@@ -117,7 +117,7 @@ public function testOnReportGenerateFormsContext()
         $mockQueryBuilder = $this->createMock(QueryBuilder::class);
         $mockEvent        = $this->getMockBuilder(ReportGeneratorEvent::class)
             ->disableOriginalConstructor()
-            ->setMethods([
+            ->onlyMethods([
                 'getContext',
                 'getQueryBuilder',
                 'addCategoryLeftJoin',
@@ -145,7 +145,7 @@ public function testOnReportGenerateFormSubmissionContext()
         $mockQueryBuilder = $this->createMock(QueryBuilder::class);
         $mockEvent        = $this->getMockBuilder(ReportGeneratorEvent::class)
             ->disableOriginalConstructor()
-            ->setMethods([
+            ->onlyMethods([
                 'getContext',
                 'getQueryBuilder',
                 'addCategoryLeftJoin',

diff --git a/app/bundles/IntegrationsBundle/Tests/Unit/Entity/ObjectMappingRepositoryTest.php b/app/bundles/IntegrationsBundle/Tests/Unit/Entity/ObjectMappingRepositoryTest.php
@@ -63,7 +63,7 @@ protected function setUp(): void
         // This is terrible, but the Query class is final and AbstractQuery doesn't have some methods used.
         $this->query = $this->getMockBuilder(AbstractQuery::class)
             ->disableOriginalConstructor()
-            ->setMethods(['setParameters', 'setFirstResult', 'setMaxResults', 'getSingleResult', 'getSQL', '_doExecute'])
+            ->onlyMethods(['setParameters', 'setFirstResult', 'setMaxResults', 'getSingleResult', 'getSQL', '_doExecute'])
             ->getMock();
 
         $this->entityManager->expects($this->once())

diff --git a/app/bundles/IntegrationsBundle/Tests/Unit/Sync/Helper/SyncDateHelperTest.php b/app/bundles/IntegrationsBundle/Tests/Unit/Sync/Helper/SyncDateHelperTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
     {
         $this->syncDateHelper = $this->getMockBuilder(SyncDateHelper::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getLastSyncDateForObject'])
+            ->onlyMethods(['getLastSyncDateForObject'])
             ->getMock();
     }
 

diff --git a/app/bundles/LeadBundle/Tests/Controller/Api/FieldApiControllerTest.php b/app/bundles/LeadBundle/Tests/Controller/Api/FieldApiControllerTest.php
@@ -47,7 +47,7 @@ public function testgetWhereFromRequestWithSomeWhere()
         ];
 
         $request = $this->getMockBuilder(Request::class)
-            ->setMethods(['get'])
+            ->onlyMethods(['get'])
             ->disableOriginalConstructor()
             ->getMock();
 

diff --git a/app/bundles/LeadBundle/Tests/Entity/LeadRepositoryTest.php b/app/bundles/LeadBundle/Tests/Entity/LeadRepositoryTest.php
@@ -86,7 +86,7 @@ public function testBuildQueryForGetLeadsByFieldValue()
 
         $mock = $this->getMockBuilder(LeadRepository::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntityManager'])
+            ->onlyMethods(['getEntityManager'])
             ->getMock();
 
         $mock->method('getEntityManager')
@@ -110,13 +110,13 @@ public function testGetLeadsByFieldValueArrayMapReturn()
     {
         $mock = $this->getMockBuilder(LeadRepository::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntities', 'buildQueryForGetLeadsByFieldValue'])
+            ->onlyMethods(['getEntities', 'buildQueryForGetLeadsByFieldValue'])
             ->getMock();
 
         // Mock the
         $mockEntity = $this->getMockBuilder(Lead::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loadMetadata'])
+            ->onlyMethods(['loadMetadata'])
             ->getMock();
 
         $mockEntity->setEmail('test@example.com');

diff --git a/app/bundles/LeadBundle/Tests/Entity/TagRepositoryTest.php b/app/bundles/LeadBundle/Tests/Entity/TagRepositoryTest.php
@@ -24,7 +24,7 @@ public function testGetTagByNameOrCreateNewOneWithSomeExistingTag()
 
         $mockRepository = $this->getMockBuilder(TagRepository::class)
             ->disableOriginalConstructor()
-            ->setMethods(['findOneBy'])
+            ->onlyMethods(['findOneBy'])
             ->getMock();
 
         $mockRepository->expects($this->once())
@@ -39,7 +39,7 @@ public function testGetTagByNameOrCreateNewOneWithSomeNewTag()
     {
         $mockRepository = $this->getMockBuilder(TagRepository::class)
             ->disableOriginalConstructor()
-            ->setMethods(['findOneBy'])
+            ->onlyMethods(['findOneBy'])
             ->getMock();
 
         $mockRepository->expects($this->once())

diff --git a/app/bundles/LeadBundle/Tests/EventListener/ReportSubscriberTest.php b/app/bundles/LeadBundle/Tests/EventListener/ReportSubscriberTest.php
@@ -891,7 +891,7 @@ public function testonReportGraphGenerate($event)
 
         $mockStmt = $this->getMockBuilder(PDOStatement::class)
             ->disableOriginalConstructor()
-            ->setMethods(['fetchAll'])
+            ->onlyMethods(['fetchAll'])
             ->getMock();
 
         $this->reportGraphEventMock->expects($this->once())
@@ -900,7 +900,7 @@ public function testonReportGraphGenerate($event)
 
         $mockChartQuery = $this->getMockBuilder(ChartQuery::class)
             ->disableOriginalConstructor()
-            ->setMethods([
+            ->onlyMethods([
                 'modifyCountQuery',
                 'modifyTimeDataQuery',
                 'loadAndBuildTimeData',

diff --git a/app/bundles/LeadBundle/Tests/Helper/FieldAliasHelperTest.php b/app/bundles/LeadBundle/Tests/Helper/FieldAliasHelperTest.php
@@ -28,7 +28,7 @@ protected function setUp(): void
 
         $this->fieldRepository = $this->createMock(LeadFieldRepository::class);
         $this->fieldModel      = $this->getMockBuilder(FieldModel::class)
-            ->setMethods(['cleanAlias', 'getRepository'])
+            ->onlyMethods(['cleanAlias', 'getRepository'])
             ->disableOriginalConstructor()
             ->getMock();
 

diff --git a/app/bundles/LeadBundle/Tests/Model/CompanyModelTest.php b/app/bundles/LeadBundle/Tests/Model/CompanyModelTest.php
@@ -26,7 +26,7 @@ public function testArrayValueIsFlattenedBeforeSave()
         /** @var CompanyModel $companyModel */
         $companyModel = $this->getMockBuilder(CompanyModel::class)
             ->disableOriginalConstructor()
-            ->setMethods(null)
+            ->onlyMethods(null)
             ->getMock();
 
         $company = new Company();

diff --git a/app/bundles/LeadBundle/Tests/Model/ImportModelTest.php b/app/bundles/LeadBundle/Tests/Model/ImportModelTest.php
@@ -62,7 +62,7 @@ public function testCheckParallelImportLimitWhenMore()
     {
         $entity = $this->initImportEntity();
         $model  = $this->getMockBuilder(ImportModel::class)
-            ->setMethods(['getParallelImportLimit', 'getRepository'])
+            ->onlyMethods(['getParallelImportLimit', 'getRepository'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -71,7 +71,7 @@ public function testCheckParallelImportLimitWhenMore()
             ->will($this->returnValue(4));
 
         $repository = $this->getMockBuilder(ImportRepository::class)
-            ->setMethods(['countImportsWithStatuses'])
+            ->onlyMethods(['countImportsWithStatuses'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -92,7 +92,7 @@ public function testCheckParallelImportLimitWhenEqual()
     {
         $entity = $this->initImportEntity();
         $model  = $this->getMockBuilder(ImportModel::class)
-            ->setMethods(['getParallelImportLimit', 'getRepository'])
+            ->onlyMethods(['getParallelImportLimit', 'getRepository'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -101,7 +101,7 @@ public function testCheckParallelImportLimitWhenEqual()
             ->will($this->returnValue(4));
 
         $repository = $this->getMockBuilder(ImportRepository::class)
-            ->setMethods(['countImportsWithStatuses'])
+            ->onlyMethods(['countImportsWithStatuses'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -122,7 +122,7 @@ public function testCheckParallelImportLimitWhenLess()
     {
         $entity = $this->initImportEntity();
         $model  = $this->getMockBuilder(ImportModel::class)
-            ->setMethods(['getParallelImportLimit', 'getRepository'])
+            ->onlyMethods(['getParallelImportLimit', 'getRepository'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -131,7 +131,7 @@ public function testCheckParallelImportLimitWhenLess()
             ->will($this->returnValue(6));
 
         $repository = $this->getMockBuilder(ImportRepository::class)
-            ->setMethods(['countImportsWithStatuses'])
+            ->onlyMethods(['countImportsWithStatuses'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -151,7 +151,7 @@ public function testCheckParallelImportLimitWhenLess()
     public function testBeginImportWhenParallelLimitHit()
     {
         $model = $this->getMockBuilder(ImportModel::class)
-            ->setMethods(['checkParallelImportLimit', 'setGhostImportsAsFailed', 'saveEntity', 'getParallelImportLimit'])
+            ->onlyMethods(['checkParallelImportLimit', 'setGhostImportsAsFailed', 'saveEntity', 'getParallelImportLimit'])
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -187,7 +187,7 @@ public function testBeginImportWhenParallelLimitHit()
     public function testBeginImportWhenDatabaseException()
     {
         $model = $this->getMockBuilder(ImportModel::class)
-            ->setMethods(['checkParallelImportLimit', 'setGhostImportsAsFailed', 'saveEntity', 'logDebug', 'process'])
+            ->onlyMethods(['checkParallelImportLimit', 'setGhostImportsAsFailed', 'saveEntity', 'logDebug', 'process'])
             ->disableOriginalConstructor()
             ->getMock();
 

diff --git a/app/bundles/LeadBundle/Tests/Model/LeadListModelTest.php b/app/bundles/LeadBundle/Tests/Model/LeadListModelTest.php
@@ -14,15 +14,15 @@ protected function setUp(): void
     {
         $mockListModel = $this->getMockBuilder(ListModel::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntities', 'getEntity'])
+            ->onlyMethods(['getEntities', 'getEntity'])
             ->getMock();
 
         $mockListModel->expects($this->any())
             ->method('getEntity')
             ->willReturnCallback(function ($id) {
                 $mockEntity = $this->getMockBuilder(LeadList::class)
                     ->disableOriginalConstructor()
-                    ->setMethods(['getName'])
+                    ->onlyMethods(['getName'])
                     ->getMock();
 
                 $mockEntity->expects($this->once())