Turn this package into a wrapper for protobuf/encoding/protodelim #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is now ready for review (Go Protobuf v1.31.0 contains the fix we needed) |
matttproud
reviewed
Jan 10, 2024
stapelberg
commented
Jan 11, 2024
|
Looks good. I think we can merge it pretty readily. |
|
Great stuff! Ready when you are :) |
matttproud
requested changes
Jan 12, 2024
Since Go Protobuf v1.30.0, the protodelim package is available upstream. The only notable API difference is that protodelim does not return the number of bytes read, which is why I added the countingReader type to pbutil/decode.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Go Protobuf v1.30.0, the protodelim package is available upstream.
The only notable API difference is that protodelim does not return the number of bytes read, which is why I added the countingReader type to pbutil/decode.go.
fixes #21
I’m creating this as a draft pull request because https://go-review.git.corp.google.com/c/protobuf/+/505555 needs to get merged and released before the tests pass (
TestReadDelimitedPrematureHeadercurrently panics). Feel free to review already if you want — I don’t foresee any more changes other than a go.mod update.