Skip to content

Commit

Permalink
fix token refresh for GKE on Windows
Browse files Browse the repository at this point in the history
A proper solution would be to pass command line arguments as an array.
Unfortunately, this is not currently possible with shelljs. See also
shelljs/shelljs#143.

As a workaround, surround the command with quotes to at least fix
commands with spaces.

Closes #50.
  • Loading branch information
mattstern31 committed Jun 6, 2018
1 parent 1b29cc9 commit aa11723
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion node-client/src/config.ts
Expand Up @@ -130,7 +130,7 @@ export class KubeConfig {
let expiration = Date.parse(expiry);
if (expiration < Date.now()) {
if (config['cmd-path']) {
let cmd = config['cmd-path'];
let cmd = '"' + config['cmd-path'] + '"';
if (config['cmd-args']) {
cmd = cmd + ' ' + config['cmd-args'];
}
Expand Down

0 comments on commit aa11723

Please sign in to comment.