Minimal versions #79
Merged
Minimal versions #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed you seem to use
cargo upgradeto upgrade all dependencies. However, I think forcing downstream users to use the latest versions of all of your dependencies is not a great idea. Case in point, 2 days ago futures 0.3.18 got yanked. As part of routine upgrades in #77, you forced downstream users to use 0.3.18, such that now your 0.3.2 is no longer usable if I want to stick with futures 0.3.17.Here I used
cargo update -Z minimal-versionsto build aCargo.lockwith the oldest semver-compatible versions and then tried to run the tests. In order to get the tests to work I had to bump async-std to 1.5 and chrono to 0.4.1, but otherwise the tests at least work.There were some unused value warnings, which I fixed in a separate commit.
I recommend you use
cargo upgradewith the--skip-compatibleoption in the future for public library crates.