Add CdpEvent::InvalidParams variant #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryo33
commented
Feb 15, 2024
| ureq = "2.6.2" | ||
| tempfile = "3.2.0" | ||
|
|
||
| [dependencies] | ||
| chromiumoxide_pdl = { path = "../chromiumoxide_pdl", version = "0.5"} |
There was a problem hiding this comment.
I removed this line because it seems unnecessary.
ryo33
commented
Feb 15, 2024
| #deserialize_from_method | ||
| _=>CdpEvent::Other(map.next_value::<serde_json::Value>()?) | ||
| _ => CdpEvent::Other(serde_json::from_str::<serde_json::Value>(value.get()).unwrap()) |
There was a problem hiding this comment.
These unwrap() should never panic, because RawValue can only be deserialized from a valid JSON, and Value can be serialized from any valid JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Add
CdpEvent::InvalidParams(serde_json::Value), and use it if deserializing an event param for a specific method fails.There already are
CdpEvent::Other(serde_json::Value), but it's only used for unknown method ids.I use the
raw_valuefeature on serde_json to getserde_json::Valuewithout any allocation after deserializing an event param failed.