Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #28

Merged
merged 4 commits into from Jun 20, 2022
Merged

Conversation

pablodenadai
Copy link
Contributor

@pablodenadai pablodenadai commented Jun 16, 2022

Description

Steps:

  1. Upgrade husky and conventional-changelog
  2. Remove cz-conventional-changelog
  3. Run yarn upgrade-interactive --latest and fix PATCH and MINOR updates. (see guide here)
  4. Generate dependency resolutions using command below:
yarn audit --json | awk 'NR > 1 { printf(",") } {printf "%s",$0}' | awk '{printf "[%s]",$0}' | jq -r 'map(select(.type == "auditAdvisory" and ( .data.advisory.severity == "high" or .data.advisory.severity == "critical")) |  { "key": (.data.resolution.path | (split(">")| join("/")) | tostring), "value": .data.advisory.patched_versions }) | from_entries'
  1. Apply resolutions and re-run yarn audit

Report:

0 vulnerabilities found - Packages audited: 660
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

TCM-100

Does this PR introduce a breaking change?

  • Yes
  • No

@pablodenadai pablodenadai force-pushed the pdn/tcm-100-upgrade-deps branch 3 times, most recently from e98c001 to f886103 Compare June 16, 2022 22:25
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
colinyip
colinyip previously approved these changes Jun 19, 2022
jhill-mattr
jhill-mattr previously approved these changes Jun 20, 2022
colinyip
colinyip previously approved these changes Jun 20, 2022
Copy link

@Marcus-Mattr Marcus-Mattr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pablodenadai pablodenadai merged commit 07cfae1 into master Jun 20, 2022
@pablodenadai pablodenadai deleted the pdn/tcm-100-upgrade-deps branch June 20, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants