Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent prototype pollution of returned diff object #87

Merged
merged 2 commits into from Nov 12, 2022
Merged

Conversation

mattphillips
Copy link
Owner

@mattphillips mattphillips commented Nov 12, 2022

Fixes #85

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (55f9c3c) compared to base (ba84464).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          109       102    -7     
  Branches        36        36           
=========================================
- Hits           109       102    -7     
Impacted Files Coverage Δ
src/added.js 100.00% <100.00%> (ø)
src/deleted.js 100.00% <100.00%> (ø)
src/diff.js 100.00% <100.00%> (ø)
src/updated.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@Retr02332 Retr02332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my tests, I can no longer contaminate the prototype:

image

@Retr02332
Copy link

Since the library was the one who executed the vulnerable action, it must be the one who validates the prototype. Therefore, if it is a security flaw.

Thank you very much for fixing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical security vulnerability
3 participants