Update SQLite3_ The columntypescantype method of type #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for this change is that the original reflected values are nil. I found that there was no good mapping when dealing with the code here
Update 'ColumnTypeScanType' method, Different types of mapping values
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 46.80% 45.97% -0.84%
==========================================
Files 11 11
Lines 1457 1479 +22
==========================================
- Hits 682 680 -2
- Misses 640 663 +23
- Partials 135 136 +1
Continue to review full report at Codecov.
|
mattn
reviewed
Jan 22, 2021
| // | ||
| // Use of this source code is governed by an MIT-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
There was a problem hiding this comment.
Sorry, I didn't notice that.
|
Tests passed on my environment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SQLite3_ The columntypescantype method of type,
The original method always returns nil