feature: Allow custom window functions to be registered with the driver #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mattn, how can I help in getting this merged? |
|
Sorry my delay. I'll look into it in later. |
|
Look good for me. @rittneje any opinion? |
|
A friendly bump on this @rittneje |
|
@mattn This would be very helpful to get in for the users of https://github.com/goccy/bigquery-emulator I cannot merge my feature branch into the project as it uses a forked Is there anything else I could do to push this along? |
|
Yes, I'm thinking this is useful but I want to wait @rittneje 's opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the registration of user-defined window functions. It extends the existing
RegisterAggregatorinterface to allow theimplto implementInverseandValue, in which case, the aggregator can be used both as a regular aggregate function and a window function.Closes #1215