Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsNullCallbackArg #1170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andrzh
Copy link
Contributor

@andrzh andrzh commented Jun 8, 2023

It took some digging to find out that NULL is passed into custom functions as a nil byte slice:

// Interpret NULL as a nil byte slice.

It would be nice to have this function s.t. future callers just need to call IsNullCallbackArg to determine whether the argument to their function is null.

Also, some minor auto-formatting.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.52 🎉

Comparison is base (f08f1b6) 46.72% compared to head (274eefa) 47.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   46.72%   47.25%   +0.52%     
==========================================
  Files          12       12              
  Lines        1526     1528       +2     
==========================================
+ Hits          713      722       +9     
+ Misses        671      663       -8     
- Partials      142      143       +1     
Impacted Files Coverage Δ
sqlite3.go 52.86% <ø> (ø)
callback.go 62.31% <60.00%> (+3.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants