all: format with Go 1.19 #1130
Open
all: format with Go 1.19 #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/fmt
branch
4 times, most recently
from
7bc5411
to
63fdc16
Compare
dolmen
reviewed
Oct 17, 2023
doc.go
Outdated
| return; | ||
| } | ||
| sqlite3_result_int(context, 1); | ||
| } |
There was a problem hiding this comment.
Lines 39 to 53 must be indented further.
There was a problem hiding this comment.
Good catch - fixed.
|
@mattn Please consider merging this. This is blocking further efforts aiming to improve documentation. |
Update Go source files to use the '//go:build' lines introduced by Go 1.17 and the doc comment formatting introduced by Go 1.19. This formatting is not changed by Go 1.20. Note: doc.go had to be changed in some places to remove double indentation.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 46.80% 46.59% -0.22%
==========================================
Files 12 12
Lines 1534 1526 -8
==========================================
- Hits 718 711 -7
+ Misses 673 672 -1
Partials 143 143
☔ View full report in Codecov by Sentry. |
|
@mattn We definitely need this change merged before submitting further documentation improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Go source files to use the '//go:build' lines introduced by Go 1.17 and the doc comment formatting introduced by Go 1.19. This formatting is not changed by Go 1.20.
Note:
doc.goand the*userauth*files had to be manually changed in some places to fix indentation.This does not change how
godoc(at least with Go 1.19) renders the package documentation and is backwards compatible (i.e. earlier versions ofgofmtwill leave this code unchanged - tested with 1.17).