New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for sqlite_math_functions tag #1059
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9a3db62
Add build tag sqlite_math_functions to enable built-in scalar math fu…
nkt-dk a2ece2e
Test if math functions are compiled in
lggruspe 68833c4
Add link to SQLite docs on built-in math functions
lggruspe ebe26e1
Fix copyright notice
lggruspe fe6ab89
Use db.Query instead of db.Exec for select statement in test
lggruspe d37b86e
Use QueryRow in test
lggruspe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Copyright (C) 2022 Yasuhiro Matsumoto <mattn.jp@gmail.com>. | ||
// | ||
// Use of this source code is governed by an MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// +build sqlite_math_functions | ||
|
||
package sqlite3 | ||
|
||
/* | ||
#cgo CFLAGS: -DSQLITE_ENABLE_MATH_FUNCTIONS | ||
#cgo LDFLAGS: -lm | ||
*/ | ||
import "C" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// +build sqlite_math_functions | ||
|
||
package sqlite3 | ||
|
||
import ( | ||
"database/sql" | ||
"testing" | ||
) | ||
|
||
func TestMathFunctions(t *testing.T) { | ||
db, err := sql.Open("sqlite3", ":memory:") | ||
if err != nil { | ||
t.Fatal("Failed to open database:", err) | ||
} | ||
defer db.Close() | ||
|
||
queries := []string{ | ||
`SELECT acos(1)`, | ||
`SELECT log(10, 100)`, | ||
`SELECT power(2, 2)`, | ||
} | ||
|
||
for _, query := range queries { | ||
if _, err := db.Query(query); err != nil { | ||
t.Fatal("Failed to call math function:", err) | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now you are dropping the
Rows
object. That means you are only checking for an error fromsqlite3_prepare_v2
and notsqlite3_step
. For completeness we should check both, which is whyQueryRow
would be preferable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... thanks for the review :)