Build amalgamation from full source to enable UPDATE_DELETE_LIMIT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one thing missing from this PR is the test I wrote for the main repo. But that test shouldn't be introduced until the bindings are updated anyway... |
|
Hello @mattn! Have you had a chance to try this out yet? |
|
Hi again! What's the status of this? Should I close this PR and the corresponding mattn/go-sqlite3#802, or would you still be interested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go.
To compare, also run it with
-cflags="": it should produce the same amalgamation currently used (except for the minor formatting change I introduced).