Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpret "na" as narrow #44

Merged
merged 3 commits into from Mar 31, 2021
Merged

Interpret "na" as narrow #44

merged 3 commits into from Mar 31, 2021

Commits on Aug 14, 2020

  1. Rename table for Na class to narrow 

    According to tr11, the "Na" category stands for
"East Asian Narrow", but the generation script named the
table "notassigned".  Rename the table to "narrow"
for consistency with the unicode annex.
    @wedaly
    wedaly committed Aug 14, 2020
    Copy the full SHA
    4709655 View commit details
    Browse the repository at this point in the history

  2. Assign narrow characters width 1 

    The narrow category applies to all ASCII characters, as well as
characters such as double angle brackets.  The tr11 annex says
that these characters are "always narrow and have explicit fullwidth
or wide counterparts", which I believe means they should be
assigned width one.

Previously, these characters were being assigned width 0.
I think before v0.0.5 they were being assigned width one,
but somewhere between v0.0.4 and v0.0.7 it changed to width 0
(maybe when introducing the generation script?).
    @wedaly
    wedaly committed Aug 14, 2020
    Copy the full SHA
    1e492b2 View commit details
    Browse the repository at this point in the history

  3. Include ASCII characters in "na" table 

    Since we're now assigning "na" (narrow) characters width 1,
we can include the ASCII character ranges in the table.
    @wedaly
    wedaly committed Aug 14, 2020
    Copy the full SHA
    e7278bc View commit details
    Browse the repository at this point in the history