Interpret "na" as narrow #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to tr11, the "Na" category stands for "East Asian Narrow", but the generation script named the table "notassigned". Rename the table to "narrow" for consistency with the unicode annex.
The narrow category applies to all ASCII characters, as well as characters such as double angle brackets. The tr11 annex says that these characters are "always narrow and have explicit fullwidth or wide counterparts", which I believe means they should be assigned width one. Previously, these characters were being assigned width 0. I think before v0.0.5 they were being assigned width one, but somewhere between v0.0.4 and v0.0.7 it changed to width 0 (maybe when introducing the generation script?).
Since we're now assigning "na" (narrow) characters width 1, we can include the ASCII character ranges in the table.
wedaly
force-pushed
the
narrow-characters
branch
from
9d7065f
to
e7278bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 160 162 +2
=========================================
+ Hits 160 162 +2
Continue to review full report at Codecov.
|
This was referenced Oct 10, 2020
|
Sorry my long delay. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to tr11, the "na" designation stands for "East Asian Narrow". This includes both ASCII characters as well as some non-ASCII characters like double angle brackets. Previous versions of go-runewidth (v0.0.4) assigned these a width of one, but more recent versions assign it a width of zero. I noticed this because tcell versions after this commit refused to display the double angle bracket characters.
The fix proposed in this PR is to assign characters with the "na" designation a width of one.