-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more endpoints and some bug fixes #172
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 87.51% // Head: 88.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 87.51% 88.37% +0.86%
==========================================
Files 15 16 +1
Lines 1354 1437 +83
==========================================
+ Hits 1185 1270 +85
+ Misses 125 123 -2
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi! Drive-by comment, because I've been looking at this repo and thinking about a problem you're touching: I suspect that adding "parameter" struct arguments would be more durable than adding individual functions for every type of parameter you wish to pass. For example, in this change, you propose adding GetNotificationsExclude with a string[] of excludes:
For endpoints that need to be added with > a dozen [0] optional parameters, this is not going to work. I'd propose, instead, modifying GetNotifications to take a new parameter struct as an argument:
I think that "param" structs with one field per potential argument would be easy for users of this API, by making the behavior much more consistent. By keeping the names of the functions matching the API endpoint names, and providing a consistent mechanism for specifying all params, we can reduce confusion and provide a single style for supporting all endpoints and params. [0] https://docs.joinmastodon.org/methods/admin/accounts/#v1 |
New features
status
now has fieldfiltered
GetTimelineHashtagMultiple(...)
get multiple hashtags in one callTagInfo(...)
,TagFollow(...)
,TagUnfollow(...)
,TagsFollowed(...)
AccountsSearchResolve(...)
same asAccountsSearch(...)
with the addition of the resolve parameterGetNotificationsExclude(...)
same asGetNotifications(...)
with the option to exclude notifications of selected typedBug fixes
AddToList(...)
andRemoveFromList(...)
used the parameteraccounts_ids
instead ofaccounts_ids[]