Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to include accounts resolve param #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paultyng
Copy link

@paultyng paultyng commented Nov 7, 2022

Unsure what is the preferred way to add params that aren't currently exposed. Would you prefer a variadic parameter with modifiers or something, or just add additional methods like this? There is another param missing but I didn't need it for my usecase: following: https://docs.joinmastodon.org/methods/accounts/

@mattn
Copy link
Owner

mattn commented Nov 8, 2022

Could you please add test?

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Base: 87.16% // Head: 87.28% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (f610598) compared to base (7dfe81e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   87.16%   87.28%   +0.12%     
==========================================
  Files          15       15              
  Lines         935      944       +9     
==========================================
+ Hits          815      824       +9     
  Misses         75       75              
  Partials       45       45              
Impacted Files Coverage Δ
accounts.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattn
Copy link
Owner

mattn commented Nov 29, 2022

Sorry, test already exists.

@mattn
Copy link
Owner

mattn commented Nov 30, 2022

Could you please fix conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants