Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set termio in IsTerminal on solaris #61

Merged
merged 1 commit into from May 26, 2021
Merged

Don't set termio in IsTerminal on solaris #61

merged 1 commit into from May 26, 2021

Commits on May 26, 2021

  1. Don't set termio in IsTerminal on solaris 

    The current implementation of IsTerminal on solaris uses IoctlSetTermio
which will set a zero valued termio on the given FD. This might lead to
unexpected side effects. Instead, use IoctlGetTermio which will not
change the terminal settings.

Also adjust the reference to isatty in the Illumos source.
    @tklauser
    tklauser committed May 26, 2021
    Copy the full SHA
    518b0c1 View commit details
    Browse the repository at this point in the history