Don't set termio in IsTerminal on solaris #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of IsTerminal on solaris uses IoctlSetTermio which will set a zero valued termio on the given FD. This might lead to unexpected side effects. Instead, use IoctlGetTermio which will not change the terminal settings. Also adjust the reference to isatty in the Illumos source.
tklauser
force-pushed
the
fix-solaris-isterminal
branch
from
e9b6183
to
518b0c1
Compare
|
Right. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of IsTerminal on solaris uses IoctlSetTermio
which will set a zero valued termio on the given FD. This might lead to
unexpected side effects. Instead, use IoctlGetTermio which will not
change the terminal settings.
Also adjust the reference to isatty in the Illumos source.