Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null with no matches and nix "this month" and "this year." #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return null with no matches and nix "this month" and "this year." #14

wants to merge 2 commits into from

Commits on Jun 29, 2013

  1. Ignore node_modules

    @davidkaneda
    davidkaneda committed Jun 29, 2013
    Configuration menu
    Copy the full SHA
    588aa7f View commit details
    Browse the repository at this point in the history

  2. Return null with no matches and nix "this month" and "this year." 

    This is a bit of a subjective patch: It changes the behavior so that unmatched entries return null.

Previously, there was code that looked to throw an error in this situation, though the code wasn't constructed right and would never throw. When implemented properly, the code errors on "this year" and "this month" as they both fulfill the "error" requirement of Date.js output matching "now."

I think it would be good if we always expect something consistent out of date.js — which I believe is a specific time & date based off the input. ie, the library should support:

* "Next tuesday," or "tomorrow" (guessing the time based off of now)
* Tomorrow at 3pm
* Now (this should probably be added...)
* etc.

But it should _not_ support:
* Every 5 minutes (iterative time increments)
* For the next 3 months (span of time)
* "This month" and "this year" (vague)

Just a thought, discussion welcome :)
    @davidkaneda
    davidkaneda committed Jun 29, 2013
    Configuration menu
    Copy the full SHA
    94a813d View commit details
    Browse the repository at this point in the history