Remove dependencies on wheels unstable API. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - looks good to me. Would you mind merging when CI passes? |
TravisCI seems to timeout before it can run. I also can't manually re-run those jobs on a PR. |
mayeut
reviewed
Jan 4, 2022
|
I guess the question is should I merge this when TravisCI has timed out and what's going to be done about TravisCI in the long term since it only seems to become more unreliable? |
|
Yes, please do merge after rebase (looks like). And for Travis-CI - yes - we should plan to drop it as soon as possible. One of us should go through and check, record what we are losing, when we do - I will have a chance to do that next week if you can't get to it before. |
Small wheel functions have been inlined. The packaging module is used which has a stable API for parsing wheel names. Type hinting added to relevant functions.
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
HexDecimal
force-pushed
the
replace-wheel
branch
from
b19acc3
to
38ab034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from pypa/wheel#433. There are plans on refactoring wheel which will likely break Delocate again. This PR will prevent that from happening.
Small single-used wheel functions are now inline. The packaging module was added which has a stable API for parsing wheel names. Type hinting added to relevant functions.