Fix plugin config parsing #7729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccbrown
added
1: PM Review
ccbrown
force-pushed
the
plugin-config-parsing-fix
branch
from
79713d3
to
8a8fb28
Compare
jwilander
approved these changes
Oct 27, 2017
enahum
approved these changes
Oct 27, 2017
jasonblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran into some trouble trying to put together a plugin. Maps with user-controlled keys in Viper configurations don't really work. In particular, periods in map keys make weird things happen. So reverse-dns plugin ids like "com.mattermost.plugins.jira" weren't working.
See spf13/viper#324 and spf13/viper#348.
I think it's probably best if we just avoid maps in configurations.@jasonblais Are we okay with a breaking change for the JIRA plugin? Users would have to reconfigure it.I'll need to put in a webapp PR as well, so no one merge this until I do that.Edit: Figured out a less impactful workaround. Let's just go with that for now.
Ticket Link
N/A
Checklist
N/A