Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: measure-text security vulnerability #5

Merged
merged 3 commits into from
Aug 19, 2019
Merged

fix: measure-text security vulnerability #5

merged 3 commits into from
Aug 19, 2019

Conversation

matt-d-rat
Copy link
Owner

Description

This PR fixes the security vulnerability in an upstream dependency of measure-text@0.0.4 (see issue #4) by absorbing the source code of measure-text@0.0.4 until such time as the issue is addressed in the upstream dependency itself.

  • Removed measure-text dependency
  • Added measure-text source code as a utility function
  • Updated middle-truncate.jsx to use the utility function

Pull Request Checklist

  • Unit tests have passed.
  • Code linting has passed.

@matt-d-rat matt-d-rat added the security This issue concerns a security vulnerability label Aug 19, 2019
@matt-d-rat matt-d-rat self-assigned this Aug 19, 2019
@matt-d-rat matt-d-rat merged commit 3104743 into master Aug 19, 2019
@matt-d-rat matt-d-rat deleted the bug/measure-text-security-vulnerability branch August 19, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matt-d-rat matt-d-rat

Labels
security This issue concerns a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matt-d-rat