Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Build Docker images with Python 3.12 #16671

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

frebib
Copy link

@frebib frebib commented Nov 21, 2023

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@frebib frebib requested a review from a team as a code owner November 21, 2023 15:12
Signed-off-by: Joe Groocock <me@frebib.net>
@frebib
Copy link
Author

frebib commented Nov 21, 2023

I'm not entirely sure if there's a reason that Synapse hasn't been updated yet, but python 3.12 has been out for a while, and I've been running this for a while on my homeserver with seemingly no issues

@clokep
Copy link
Contributor

clokep commented Nov 21, 2023

I'm not entirely sure if there's a reason that Synapse hasn't been updated yet

I think just being a bit conservative to see if there's any major bugs in Python 3.12.0. So, no real reason.

@clokep
Copy link
Contributor

clokep commented Nov 29, 2023

We had a conversation about this at https://matrix.to/#/!vcyiEtMVHIhWXcJAfl:sw1v.org/$jKrddG8OwjueQLieMigclhpg6zFltijWQUPE2xPDsSQ?via=matrix.org&via=element.io&via=envs.net -- it seems that we'd like to wait a bit more for this since we're still seeing Python 3.12 support being added to packages. We previously always ran a version behind on Python to be conservative, but broke this in Python 3.11 (since it has a significant performance improvements).


Out of curiosity -- is there anything driving this? Do you see better performance when building with 3.12, or just interested in running the latest?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants