Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add check to ensure locked dependencies have source distributions available. #14742

Merged
merged 10 commits into from
Feb 13, 2023
Merged

Add check to ensure locked dependencies have source distributions available. #14742

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0aa18a2
Add a script to check the lockfile for dependencies without sdists.
reivilibre Dec 28, 2022
4bb82b4
Add dependency on tomli
reivilibre Dec 28, 2022
e1148cc
Add workflow to ensure locked deps have sdists
reivilibre Dec 28, 2022
4644a90
Newsfile
reivilibre Dec 28, 2022
3b2d6e2
Support the other style of lockfile
reivilibre Dec 28, 2022
170abb7
Revert lockfile changes from "Add dependency on tomli"
reivilibre Feb 13, 2023
c02c919
Merge branch 'develop' into rei/lockdeps_have_sdists
reivilibre Feb 13, 2023
33bab13
Update the lockfile content hash only (needed to clear poetry caches)
reivilibre Feb 13, 2023
44847bf
Remove write privileges
reivilibre Feb 13, 2023
2e75a31
Only bother with Poetry 1.3+ lockfiles
reivilibre Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/poetry_lockfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
on:
push:
branches: ["develop", "release-*"]
paths:
- poetry.lock
pull_request:
paths:
- poetry.lock
Comment on lines +1 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we only trigger this if needed.

The downside is that it can't be fed into the tests-done job to tell github it's safe to merge this PR. But I think we can live with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's frustrating how the default behaviour isn't just to make sure all the tests pass, but ah well


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: write
reivilibre marked this conversation as resolved.
Show resolved Hide resolved

jobs:
check-sdists:
name: "Check locked dependencies have sdists"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.x'
- run: pip install tomli
- run: ./scripts-dev/check_locked_deps_have_sdists.py