indexeddb: expose new method IndexeddbCryptoStore::open_with_key
#3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3423 +/- ##
==========================================
- Coverage 82.97% 82.96% -0.01%
==========================================
Files 246 246
Lines 25022 25029 +7
==========================================
+ Hits 20761 20765 +4
- Misses 4261 4264 +3 ☔ View full report in Codecov by Sentry. |
Allow applications which already have a cryptographically-secure key to avoid PBKDF, by passing that key in directly.
richvdh
commented
May 16, 2024
poljar
approved these changes
May 21, 2024
richvdh
commented
May 21, 2024
Co-authored-by: Damir Jelić <poljar@termina.org.uk> Signed-off-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a resolution to element-hq/element-web#26821: allow applications to skip the PBKDF2 operation if they already have a cryptographically secure key.
In order to maintain compatibility for existing element-web sessions, if we discover that we have an existing store that was encrypted with a key derived from PBKDF2, then we reconstruct what element-web used to do: specifically, we base64-encode the key to obtain the "passphrase" that was previously passed in. If that matches, we know we've got the right key, and can update the meta store accordingly.