ci: Re-enable and fix NSE test #3417
Open
+74
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had to stop working on this. |
andybalaam
force-pushed
the
andybalaam/unignore-nse-test
branch
from
b5987a1
to
c7d07cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
+ Coverage 82.97% 83.19% +0.22%
==========================================
Files 246 246
Lines 24958 24958
==========================================
+ Hits 20708 20765 +57
+ Misses 4250 4193 -57 ☔ View full report in Codecov by Sentry. |
|
Hah, managed to make it permafail in the CodeCov task just by rejiggering the logic. I propose to shelve the PR, but keep it open; as soon as anyone has a bit of free time, they should feel free to investigate it, because it does seem to exhibit some real issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes #3411 less bad because it should fail fast.
It also seems to make it fail less often, so it might be worth re-enabling the test (which this PR does) and seeing whether it gives us clues.
Re-opening this PR as @bnjbvr suggested it might be worth re-enabling the test. I'm happy to leave it disabled, delete it, or re-enable it as people wish.