crypto: MemoryStore uses backup versions to track which sessions are backed up #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/fast-backup-reset-in-memorystore2
branch
from
8c47095
to
a7b2bb1
Compare
andybalaam
requested review from
bnjbvr and
poljar
and removed request for
a team and
bnjbvr
andybalaam
force-pushed
the
andybalaam/fast-backup-reset-in-memorystore2
branch
from
a7b2bb1
to
33e8fe1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
==========================================
+ Coverage 83.20% 83.22% +0.01%
==========================================
Files 247 247
Lines 25022 25048 +26
==========================================
+ Hits 20819 20845 +26
Misses 4203 4203 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Apr 29, 2024
|
OK, better late than never, I've made changes in response to the review. Thanks! |
andybalaam
force-pushed
the
andybalaam/fast-backup-reset-in-memorystore2
branch
from
b122797
to
2652b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/element-hq/crypto-internal/issues/208
Validate the algorithm described in element-hq/element-web#26892 (comment) by implementing it in in the
MemoryStore.Main outstanding question:
InboundGroupSession(incrates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs) has abacked_upfield. Should this be changed (e.g. tobackup_up_to) or removed? How is it used?