Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix radio for theme selection #1368

Merged
merged 1 commit into from Sep 12, 2017
Merged

fix radio for theme selection #1368

merged 1 commit into from Sep 12, 2017

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 7, 2017 •
edited

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

facebook/react#8575 broke it
normally input value/checked should be dumped to state and read from there but this works instead.

onChange now doesn't fire if you don't pass the value into the checked prop anymore.

@t3chguy
fix radio for theme selection
3df379c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
dbkr approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, we should really make the UserSettingsStore more like a store and reload all the data from the store, but I guess this would involve changing a lot of UserSettings

@dbkr dbkr merged commit d90aa6e into develop Sep 12, 2017
@t3chguy t3chguy deleted the t3chguy/fix_theme branch October 29, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t3chguy @dbkr