Refactor some logic into common AvatarSetting component #12544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We duplicated some of the logic of setting avatars between profiles & rooms. This pulls some of that logic into the AvatarSetting component and hopefully make things a little simpler.
dbkr
added
the
T-Task
florianduros
approved these changes
May 20, 2024
test/components/views/room_settings/RoomProfileSettings-test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Duros <florianduros@element.io>
richvdh
approved these changes
May 20, 2024
test/components/views/room_settings/RoomProfileSettings-test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We duplicated some of the logic of setting avatars between profiles & rooms. This pulls some of that logic into the AvatarSetting component and hopefully make things a little simpler. This component now includes the file control, the chrome workaround and the logic of displaying the pending file from a data URL.
Work on this the ProfileSettings component is coming up next.
RoomProfileSettings wins some tests because sonarcloud, and its the one I'm not about to start changing.
Checklist
public/exportedsymbols have accurate TSDoc documentation.