Update dependencies, require node 20 #775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
force-pushed
the
tadzik/dep-updates
branch
from
ec8ee33
to
b68e76c
Compare
tadzik
force-pushed
the
tadzik/dep-updates
branch
from
b68e76c
to
f280497
Compare
|
Looks sane to me, but the postgres integration test fail seems legit? edit: oh wait, looks like it's just busted, so probably not related to this PR. |
|
It's worth considering updating our matrix-appservice-bridge here and dropping NeDB while at it – we'd need to support a DB migration though. |
Half-Shot
requested changes
Apr 16, 2024
| @@ -38,7 +38,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Ideally we should make sure this works before merging.
| @@ -25,14 +25,6 @@ const log = new Logger("substitutions"); | |||
| const ATTACHMENT_TYPES = ["m.audio", "m.video", "m.file", "m.image"]; | |||
| const PILL_REGEX = /<a href="https:\/\/matrix\.to\/#\/(#|@|\+)([^"]+)">([^<]+)<\/a>/g; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Assuming this is now part of the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.