Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display channel name in list command #756

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

psrpinto
Copy link

@psrpinto psrpinto commented Jul 3, 2023

Fixes #349
Signed-off-by: Paulo Pinto paulo.pinto@automattic.com

This PR fixes issues related to saving the slack channel name in the database:

  1. Channel name was not being set by the link command
  2. Channel name was not being updated when the channel is renamed

This resulted in the channel name being displayed as UNKNOWN when issuing a link command.

Before

Screenshot 2023-07-03 at 16 25 59

After

Screenshot 2023-07-03 at 16 19 25

There are other places in the codebase where SlackChannelName is set, and this is the only place where a leading # is added.
@psrpinto psrpinto requested a review from a team as a code owner July 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pass "Room is now pending-name"
1 participant